Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore bun built-in modules #288

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Conversation

SunsetTechuila
Copy link
Contributor

@SunsetTechuila SunsetTechuila commented Jun 3, 2024

supersedes #266

npm link

Copy link

changeset-bot bot commented Jun 3, 2024

🦋 Changeset detected

Latest commit: fcfd225

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-import-resolver-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Jun 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@SunsetTechuila

This comment was marked as outdated.

Copy link

socket-security bot commented Jun 16, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@SunsetTechuila SunsetTechuila changed the title feat: add bun built-in modules support fix: ignore bun built-in modules Jun 16, 2024
@SunsetTechuila
Copy link
Contributor Author

@JounQin hello, would appreciate a review from you

@SunsetTechuila
Copy link
Contributor Author

@SukkaW would you mind reviewing my pr as well please? it doesn't look like JounQin will have time for that any time soon

@SukkaW
Copy link
Collaborator

SukkaW commented Jul 13, 2024

@SukkaW would you mind reviewing my pr as well please? it doesn't look like JounQin will have time for that any time soon

Currently, I don't have access to the eslint-import-resolver-typescript package yet, thus I can't get my hand on maintaining this. The PR LGTM though.

@JounQin
Copy link
Collaborator

JounQin commented Jul 14, 2024

@SunsetTechuila Sorry for the delay, could be rebase this PR?

@ljharb Is that possible to add @SukkaW as collaborator of this repository also?

@ljharb
Copy link
Member

ljharb commented Jul 14, 2024

done

@SunsetTechuila
Copy link
Contributor Author

rebased

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/inherits@2.0.4 None 0 3.96 kB isaacs
npm/is-bun-module@1.0.2 None +1 105 kB sunset_techuila
npm/kind-of@6.0.3 None 0 22.8 kB doowb
npm/safer-buffer@2.1.2 None 0 42.3 kB chalker
npm/source-map@0.6.1 None 0 805 kB tromey
npm/util-deprecate@1.0.2 None 0 5.48 kB tootallnate

🚮 Removed packages: npm/get-stream@6.0.1, npm/postcss@8.4.32, npm/regexp-tree@0.1.27

View full report↗︎

@JounQin JounQin added this pull request to the merge queue Jul 14, 2024
Merged via the queue into import-js:master with commit a4c6c78 Jul 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants