Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow either import or import-x plugin as a peer dependency #294

Merged
merged 3 commits into from
Jul 14, 2024

Conversation

RobinTail
Copy link
Contributor

Fixes #293

The PR marks both import and import-x plugins as optional peer dependencies, thus disables the warning on missing import when you're using import-x instead.

Copy link

changeset-bot bot commented Jun 25, 2024

🦋 Changeset detected

Latest commit: c370a29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-import-resolver-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RobinTail RobinTail marked this pull request as draft June 25, 2024 10:12
Copy link

codesandbox-ci bot commented Jun 25, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@RobinTail
Copy link
Contributor Author

The CI fails to install Node 16 🤷🏽‍♀️

@RobinTail
Copy link
Contributor Author

RobinTail commented Jun 26, 2024

I believe enabling corepack should go after installing Node in CI
This should be fixed by:

@RobinTail RobinTail marked this pull request as ready for review June 26, 2024 18:59
@RobinTail
Copy link
Contributor Author

@JounQin please review

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/eslint-plugin-import-x@3.0.1 Transitive: environment, eval, filesystem, unsafe +44 7.92 MB jounqin

🚮 Removed packages: npm/merge2@1.4.1, npm/npm-run-path@4.0.1, npm/onetime@5.1.2, npm/rimraf@3.0.2, npm/signal-exit@3.0.7

View full report↗︎

@JounQin JounQin added this pull request to the merge queue Jul 14, 2024
Merged via the queue into import-js:master with commit 10f9b17 Jul 14, 2024
9 checks passed
@RobinTail
Copy link
Contributor Author

Please release, @JounQin

@RobinTail
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow import-x plugin, not only import
2 participants