Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflows/ci): setup node before enabling corepack #300

Merged
merged 4 commits into from
Jul 14, 2024
Merged

Conversation

JounQin
Copy link
Collaborator

@JounQin JounQin commented Jul 14, 2024

No description provided.

Copy link

changeset-bot bot commented Jul 14, 2024

⚠️ No Changeset found

Latest commit: 057794c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codesandbox-ci bot commented Jul 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Jul 14, 2024

size-limit report 📦

Path Size
./lib/index.js 2.23 KB (0%)
0 B (+100% 🔺)

Copy link

socket-security bot commented Jul 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/get-stream@6.0.1 None 0 12.2 kB sindresorhus
npm/merge2@1.4.1 None 0 8.9 kB zensh
npm/npm-run-path@4.0.1 environment 0 8.13 kB sindresorhus
npm/onetime@5.1.2 None 0 6.17 kB sindresorhus
npm/regexp-tree@0.1.27 None 0 314 kB dmitrysoshnikov
npm/rimraf@3.0.2 filesystem 0 17.3 kB isaacs
npm/signal-exit@3.0.7 None 0 9.96 kB isaacs

View full report↗︎

Copy link

socket-security bot commented Jul 14, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/nodent-runtime@3.2.1
  • Install script: install
  • Source: node build.js
🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/nodent-runtime@3.2.1

@JounQin
Copy link
Collaborator Author

JounQin commented Jul 14, 2024

@ljharb Did you change my permission on this repository? I can no longer merge this PR with privilege.

@ljharb
Copy link
Member

ljharb commented Jul 14, 2024

You have “maintain” permission; it seems like you should be able to merge it. Is the socket failure blocking it?

@JounQin JounQin added this pull request to the merge queue Jul 14, 2024
Merged via the queue into master with commit b777b44 Jul 14, 2024
11 of 12 checks passed
@JounQin JounQin deleted the fix/ci branch July 14, 2024 15:06
@JounQin
Copy link
Collaborator Author

JounQin commented Jul 14, 2024

OK, I'm not so familiar with merge queue feature, it seems not blocking now.

@JounQin
Copy link
Collaborator Author

JounQin commented Jul 14, 2024

@ljharb I'm not sure why npm permission is not recognized in CI, and I don't have permission to check the secrets used in CI any longer.

https://github.com/import-js/eslint-import-resolver-typescript/actions/runs/9928981640/job/27425949199

@ljharb
Copy link
Member

ljharb commented Jul 14, 2024

the NPM_TOKEN secret exists, but its value can’t be seen, only changed. I’m not familiar with changesets but i wouldn’t expect anything to have changed unless your own npm token changed. Hit me up privately and we can get it sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants