Merge pull request #1126 from gajus/issue-1098

feat: make no-cycle ignore Flow imports (fixes #1098)
import-js · Aug 2, 2018 · 0336ef9 · 0336ef9
2 parents 5480240 + 3feb54c
commit 0336ef9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/rules/no-cycle.js b/src/rules/no-cycle.js
@@ -30,6 +30,14 @@ module.exports = {
     function checkSourceValue(sourceNode, importer) {
       const imported = Exports.get(sourceNode.value, context)
 
+      if (sourceNode.parent && sourceNode.parent.importKind === 'type') {
+        return // no Flow import resolution
+      }
+
+      if (sourceNode._babelType === 'Literal') {
+        return // no Flow import resolution, workaround for ESLint < 5.x
+      }
+
       if (imported == null) {
         return  // no-unresolved territory
       }

diff --git a/tests/src/rules/no-cycle.js b/tests/src/rules/no-cycle.js
@@ -36,6 +36,10 @@ ruleTester.run('no-cycle', rule, {
       code: 'import { foo } from "./depth-two"',
       options: [{ maxDepth: 1 }],
     }),
+    test({
+      code: 'import type { FooType } from "./depth-one"',
+      parser: 'babel-eslint',
+    }),
   ],
   invalid: [
     test({