Add schema and further testing for newlines option on `newline-afte…

…r-import`
import-js · Feb 13, 2017 · 1d757dc · 1d757dc
1 parent 8c7ea26
commit 1d757dc
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/src/rules/newline-after-import.js b/src/rules/newline-after-import.js
@@ -45,6 +45,18 @@ function isClassWithDecorator(node) {
 module.exports = {
   meta: {
     docs: {},
+    schema: [
+      {
+        'type': 'object',
+        'properties': {
+          'newlines': {
+            'type': 'integer',
+            'minimum': 1,
+          },
+        },
+        'additionalProperties': false,
+      },
+    ],
   },
   create: function (context) {
     let level = 0

diff --git a/tests/src/rules/newline-after-import.js b/tests/src/rules/newline-after-import.js
@@ -85,6 +85,11 @@ ruleTester.run('newline-after-import', require('rules/newline-after-import'), {
       parserOptions: { sourceType: 'module' },
       options: [{ 'newlines': 2 }],
     },
+    {
+      code: `import foo from 'foo';\n\n\n\n\nvar foo = 'bar';`,
+      parserOptions: { sourceType: 'module' },
+      options: [{ 'newlines': 4 }],
+    },
     {
       code: `var foo = require('foo-module');\n\nvar foo = 'bar';`,
       parserOptions: { sourceType: 'module' },
@@ -94,6 +99,11 @@ ruleTester.run('newline-after-import', require('rules/newline-after-import'), {
       parserOptions: { sourceType: 'module' },
       options: [{ 'newlines': 2 }],
     },
+    {
+      code: `var foo = require('foo-module');\n\n\n\n\nvar foo = 'bar';`,
+      parserOptions: { sourceType: 'module' },
+      options: [{ 'newlines': 4 }],
+    },
     {
       code: `require('foo-module');\n\nvar foo = 'bar';`,
       parserOptions: { sourceType: 'module' },
@@ -173,6 +183,16 @@ ruleTester.run('newline-after-import', require('rules/newline-after-import'), {
       } ],
       parserOptions: { sourceType: 'module' },
     },
+    {
+      code: `import foo from 'foo';\nexport default function() {};`,
+      options: [{ 'newlines': 1 }],
+      errors: [ {
+        line: 1,
+        column: 1,
+        message: IMPORT_ERROR_MESSAGE,
+      } ],
+      parserOptions: { sourceType: 'module' },
+    },
     {
       code: `var foo = require('foo-module');\nvar something = 123;`,
       errors: [ {