[Namespace] add check for null ExportMap

import-js · Nov 18, 2018 · 20b9e98 · 20b9e98
1 parent 798eed7
commit 20b9e98
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/src/rules/namespace.js b/src/rules/namespace.js
@@ -186,7 +186,11 @@ module.exports = {
             }
 
             path.push(property.key.name)
-            testKey(property.value, namespace.get(property.key.name).namespace, path)
+            const dependencyExportMap = namespace.get(property.key.name)
+            // could be null when ignored or ambiguous
+            if (dependencyExportMap !== null) {
+              testKey(property.value, dependencyExportMap.namespace, path)
+            }
             path.pop()
           }
         }

diff --git a/tests/files/re-export-common.js b/tests/files/re-export-common.js
@@ -0,0 +1 @@
+export { a as foo } from './common'
diff --git a/tests/src/rules/namespace.js b/tests/src/rules/namespace.js
@@ -104,6 +104,11 @@ const valid = [
     parser: 'babel-eslint',
   }),
 
+  // #1144: should handle re-export CommonJS as namespace
+  test({
+    code: `import * as ns from './re-export-common'; const {foo} = ns;`,
+  }),
+
   // JSX
   test({
     code: 'import * as Names from "./named-exports"; const Foo = <Names.a/>',