[fix] prefer-default-export: fix cases when exporting array destruc…

…turing Fixes #706
import-js · Aug 24, 2019 · 3704801 · 3704801
1 parent 5e143b2
commit 3704801
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/rules/prefer-default-export.js b/src/rules/prefer-default-export.js
@@ -23,7 +23,10 @@ module.exports = {
           .forEach(function(property) {
             captureDeclaration(property.value)
           })
-      } else {
+      } else if (identifierOrPattern.type === 'ArrayPattern') {
+        identifierOrPattern.elements
+          .forEach(captureDeclaration)
+      } else  {
       // assume it's a single standard identifier
         specifierExportCount++
       }

diff --git a/tests/src/rules/prefer-default-export.js b/tests/src/rules/prefer-default-export.js
@@ -43,6 +43,10 @@ ruleTester.run('prefer-default-export', rule, {
       code: `
         export const { foo: { bar, baz } } = item;`,
       }),
+    test({
+      code: `
+        export const [a, b] = item;`,
+      }),
     test({
       code: `
         let item;
@@ -127,6 +131,14 @@ ruleTester.run('prefer-default-export', rule, {
         message: 'Prefer default export.',
       }],
     }),
+    test({
+      code: `
+        export const [a] = ["foo"]`,
+      errors: [{
+        ruleId: 'ExportNamedDeclaration',
+        message: 'Prefer default export.',
+      }],
+    }),
   ],
 })