[Refactor] Avoid superfluous calls and code

import-js · Dec 3, 2019 · 5607f3a · 5607f3a
1 parent 112a0bf
commit 5607f3a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/core/importType.js b/src/core/importType.js
@@ -72,14 +72,14 @@ function isRelativeToSibling(name) {
 }
 
 function typeTest(name, settings, path) {
-  if (isAbsolute(name, settings, path)) { return 'absolute' }
+  if (isAbsolute(name)) { return 'absolute' }
   if (isBuiltIn(name, settings, path)) { return 'builtin' }
   if (isInternalModule(name, settings, path)) { return 'internal' }
   if (isExternalModule(name, settings, path)) { return 'external' }
   if (isScoped(name, settings, path)) { return 'external' }
-  if (isRelativeToParent(name, settings, path)) { return 'parent' }
-  if (isIndex(name, settings, path)) { return 'index' }
-  if (isRelativeToSibling(name, settings, path)) { return 'sibling' }
+  if (isRelativeToParent(name)) { return 'parent' }
+  if (isIndex(name)) { return 'index' }
+  if (isRelativeToSibling(name)) { return 'sibling' }
   return 'unknown'
 }
 

diff --git a/src/rules/no-unused-modules.js b/src/rules/no-unused-modules.js
@@ -355,7 +355,7 @@ module.exports = {
 
       exportCount.delete(EXPORT_ALL_DECLARATION)
       exportCount.delete(IMPORT_NAMESPACE_SPECIFIER)
-      if (missingExports && exportCount.size < 1) {
+      if (exportCount.size < 1) {
         // node.body[0] === 'undefined' only happens, if everything is commented out in the file
         // being linted
         context.report(node.body[0] ? node.body[0] : node, 'No exports found')

diff --git a/src/rules/order.js b/src/rules/order.js
@@ -340,7 +340,7 @@ function makeNewlinesBetweenReport (context, imported, newlinesBetweenImports) {
         context.report({
           node: previousImport.node,
           message: 'There should be at least one empty line between import groups',
-          fix: fixNewLineAfterImport(context, previousImport, currentImport),
+          fix: fixNewLineAfterImport(context, previousImport),
         })
       } else if (currentImport.rank === previousImport.rank
         && emptyLinesBetween > 0

diff --git a/utils/resolve.js b/utils/resolve.js
@@ -64,7 +64,7 @@ function relative(modulePath, sourceFile, settings) {
 function fullResolve(modulePath, sourceFile, settings) {
   // check if this is a bonus core module
   const coreSet = new Set(settings['import/core-modules'])
-  if (coreSet != null && coreSet.has(modulePath)) return { found: true, path: null }
+  if (coreSet.has(modulePath)) return { found: true, path: null }
 
   const sourceDir = path.dirname(sourceFile)
       , cacheKey = sourceDir + hashObject(settings).digest('hex') + modulePath