chore(eslint): upgrade to eslint@4

.travis.yml

@@ -1,15 +1,21 @@
 language: node_js
 node_js:
   - 6
-  - 7
+  - 8
 
 os:
   - linux
   - osx
 
+env:
+  - ESLINT_VERSION=2
+  - ESLINT_VERSION=3
+  - ESLINT_VERSION=4
+
 install:
   - npm -g install npm@3
   - npm install
+  - npm install eslint@$ESLINT_VERSION --ignore-scripts || true
   # install all resolver deps
   - "for resolver in ./resolvers/*; do cd $resolver && npm install && cd ../..; done"
 

appveyor.yml

@@ -1,8 +1,24 @@
 # Test against this version of Node.js
 environment:
+  environment:
   matrix:
-  - nodejs_version: "7"
-  - nodejs_version: "6"
+    - nodejs_version: "8"
+      ESLINT_VERSION: "4"
+
+    - nodejs_version: "8"
+      ESLINT_VERSION: "3"
+
+    - nodejs_version: "8"
+      ESLINT_VERSION: "2"
+
+    - nodejs_version: "6"
+      ESLINT_VERSION: "4"
+
+    - nodejs_version: "6"
+      ESLINT_VERSION: "3"
+
+    - nodejs_version: "6"
+      ESLINT_VERSION: "2"
 
 # platform:
 #   - x86

package.json

@@ -74,13 +74,14 @@
     "typescript-eslint-parser": "^2.1.0"
   },
   "peerDependencies": {
-    "eslint": "2.x - 3.x"
+    "eslint": "2.x - 4.x"
   },
   "dependencies": {
     "builtin-modules": "^1.1.1",
     "contains-path": "^0.1.0",
     "debug": "^2.2.0",
     "doctrine": "1.5.0",
+    "escope": "^3.6.0",
     "eslint-import-resolver-node": "^0.2.0",
     "eslint-module-utils": "^2.0.0",
     "has": "^1.0.1",

src/rules/no-amd.js

@@ -17,7 +17,7 @@ module.exports = {
         return {
 
             'CallExpression': function (node) {
-          if (context.getScope().type !== 'module') return
+          if (context.getScope().type !== 'module' && context.getScope().type !== 'global') return
 
           if (node.callee.type !== 'Identifier') return
           if (node.callee.name !== 'require' &&

src/rules/no-commonjs.js

@@ -41,7 +41,7 @@ module.exports = {
 
       },
       'CallExpression': function (call) {
-        if (context.getScope().type !== 'module') return
+        if (context.getScope().type !== 'module' && context.getScope().type !== 'global') return
 
         if (call.callee.type !== 'Identifier') return
         if (call.callee.name !== 'require') return

src/rules/no-named-default.js

@@ -10,7 +10,7 @@ module.exports = {
           if (im.type === 'ImportSpecifier' && im.imported.name === 'default') {
             context.report({
               node: im.local,
-              message: `Use default import syntax to import \'${im.local.name}\'.` })
+              message: `Use default import syntax to import '${im.local.name}'.` })
           }
         })
       },

tests/src/rules/default.js

@@ -58,8 +58,7 @@ ruleTester.run('default', rule, {
 
     // #94: redux export of execution result,
     test({ code: 'import connectedApp from "./redux"' }),
-    test({ code: 'import App from "./jsx/App"'
-         , ecmaFeatures: { jsx: true, modules: true } }),
+    test({ code: 'import App from "./jsx/App"'}),
 
     // from no-errors
     test({

tests/src/rules/named.js

@@ -135,7 +135,6 @@ ruleTester.run('named', rule, {
 
     test({
       code: 'import { a } from "./re-export-names"',
-      args: [2, 'es6-only'],
       errors: [error('a', './re-export-names')],
     }),