-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory issues with import/order autofixer in 2.11.0 #1086
Comments
We used autofix order on a large codebase (1000s of files) where it had a failure on every file. First run through was very slow as you would expect, then it was fine after fixing. No memory issues. How many errors do you have if not fixing? |
I have assumptions what may cause memory overconsumption, but i want to reproduce the problem. @JakubJagoda in addition, please provide your node.js version. |
@lukeapage I have 0 errors, I discovered the problem by accident after adding a new file. I can't really narrow it down to a single file, because it's not a matter of a single file - whenever there's an incorrect import order in any of the files, the problem happens. When I, according to your advice, had increased the memory limit (using package
Do you also use @tihonove I am using Node 8.2.1 on x64 Windows. I wish I could give the project that causes the problem, but unfortunately I can't do that due to legal reasons. |
It seems like it might be some infinite loop to do with typescript-eslint-parser ? Can you reproduce with a new file with just 2 import statements? If so you could post the contents of that with changed file paths.. if that doesn’t reproduce, what does? |
Also running across this. also using typescript-eslint-parser with a large codebase |
@lukeapage Here's a sample repo https://github.com/justinanastos/eslint-plugin-import-1086 |
Also, FWIW, we saw this upgrading from |
Lastly, I've used |
I believe this is tested and resolved by #1137 that was merged 21 days ago. Can the maintainers please cut a release? |
As of 2.14.0 released on 2018-08-13 this issue seems to be resolved. |
@JakubJagoda is your issue resolved? I’ll be happy to reopen this if not. |
After upgrading to 2.11.0 my linting process started to fail due to running out of memory. The reason seem to be the autofixer for the import/order rule, because either
--fix
option orimport/order
rules in.eslintrc
makes it working fine again. This is what I see in the console:
I was asked to create this issue with a link back to the PR that introduced autofixer for this rule, so here it is:
#908
Just in case, here's my config for the
import/order
rule:The text was updated successfully, but these errors were encountered: