Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc update request: "no-unused-modules" should indicate that it defaults to no-op #1351

Closed
johndevedu opened this issue May 1, 2019 · 3 comments · Fixed by #1352
Closed

doc update request: "no-unused-modules" should indicate that it defaults to no-op #1351

johndevedu opened this issue May 1, 2019 · 3 comments · Fixed by #1352
Labels
docs help wanted

Comments

@johndevedu
Copy link
Contributor

Reference #1324

Until the next semver when the defaults can be set to "true", I think it would be helpful to update the doc to state that settings default to "false" for both missingExports and unusedExports. As the referenced issue states, it was not obvious to me it had to be explicitly enabled, and effectively it was a no-op on the plugin. This no-op might deter some folks from using an awesome plugin! :)
@johndevedu johndevedu changed the title doc update request: "no-unused-modules" should indicate defaults of no-op doc update request: "no-unused-modules" should indicate that it defaults to no-op May 1, 2019
johndevedu added a commit to johndevedu/eslint-plugin-import that referenced this issue May 1, 2019
@johndevedu
Indicates usage, and that plugin defaults to no-op
2bfa037 
import-js#1351
@johndevedu johndevedu mentioned this issue May 1, 2019
Merged
@johndevedu
Copy link
Contributor Author

johndevedu commented May 1, 2019 •
edited by ljharb
Loading

@ljharb just noticed that no-unused-modules is not even listed on the README.md. Can I add that to #1352 or should I open another issue?

@ljharb
Copy link
Member

ljharb commented May 2, 2019

Let’s do it all in one :-)

johndevedu added a commit to johndevedu/eslint-plugin-import that referenced this issue May 6, 2019
@johndevedu
Indicates usage, plugin defaults to no-op, and add description to mai…
297d937 
…n README.md

import-js#1351
@johndevedu
Copy link
Contributor Author

@ljharb Done with the additional change. Please lmk if I missed anything to get the PR completed. Thanks!

ljharb pushed a commit to johndevedu/eslint-plugin-import that referenced this issue May 13, 2019
@johndevedu @ljharb
[Docs] no-unused-modules: Indicates usage, plugin defaults to no-op…
2f85fbe 
…, and add description to main README.md

Fixes import-js#1351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Indicates usage, and that plugin defaults to no-op johndevedu/eslint-plugin-import
2 participants
@ljharb @johndevedu