Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-unresolved does not check dynamic import #2024

Closed
aladdin-add opened this issue Apr 6, 2021 · 1 comment · Fixed by #2026
Closed

no-unresolved does not check dynamic import #2024

aladdin-add opened this issue Apr 6, 2021 · 1 comment · Fixed by #2026
Labels
enhancement help wanted

Comments

@aladdin-add
Copy link
Contributor 

import("./component-xxx");

if the "./component-xxx" does not exists, the rule should report an error.

seems a reasonable enhencement?
@ljharb
Copy link
Member

ljharb commented Apr 6, 2021

Absolutely, for string literals or template literals without interpolations.

aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue Apr 12, 2021
@aladdin-add
fix: no-unresolved check import() (fixes import-js#2024)
3111def
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue Apr 12, 2021
@aladdin-add
fix: no-unresolved check import() (fixes import-js#2024)
8424548 
refs: https://github.com/estree/estree/blob/master/es2020.md#importexpression
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 12, 2021
@aladdin-add
fix: no-unresolved check import() (fixes import-js#2024)
4586f68 
refs: https://github.com/estree/estree/blob/master/es2020.md#importexpression

fix: dynamic import & add tests

chore: cleanup tests
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 12, 2021
@aladdin-add
fix: no-unresolved check import() (fixes import-js#2024)
423d997 
refs: https://github.com/estree/estree/blob/master/es2020.md#importexpression

fix: dynamic import & add tests

chore: cleanup tests
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 12, 2021
@aladdin-add
fix: no-unresolved check import() (fixes import-js#2024)
12d485f 
refs: https://github.com/estree/estree/blob/master/es2020.md#importexpression

fix: dynamic import & add tests

chore: cleanup tests
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 12, 2021
@aladdin-add
fix: no-unresolved check import() (fixes import-js#2024)
f605fc8 
refs: https://github.com/estree/estree/blob/master/es2020.md#importexpression

fix: dynamic import & add tests

chore: cleanup tests
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 13, 2021
@aladdin-add
fix: no-unresolved check import() (fixes import-js#2024)
7fe491c 
refs: https://github.com/estree/estree/blob/master/es2020.md#importexpression

fix: dynamic import & add tests

chore: cleanup tests
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 13, 2021
@aladdin-add
fix: no-unresolved check import() (fixes import-js#2024)
7c8aa88 
refs: https://github.com/estree/estree/blob/master/es2020.md#importexpression

fix: dynamic import & add tests

chore: cleanup tests
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 13, 2021
@aladdin-add
fix: no-unresolved check import() (fixes import-js#2024)
d65186b
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 13, 2021
@aladdin-add
fix: no-unresolved check import() (fixes import-js#2024)
2b05677
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 13, 2021
@aladdin-add
fix: no-unresolved check import() (fixes import-js#2024)
6f46b6f
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 13, 2021
@aladdin-add
fix: no-unresolved check import() (fixes import-js#2024)
8e25ec1
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 13, 2021
@aladdin-add
fix: no-unresolved check import() (fixes import-js#2024)
56c4516
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 13, 2021
@aladdin-add
fix: no-unresolved check import() (fixes import-js#2024)
46da178
ljharb pushed a commit to aladdin-add/eslint-plugin-import that referenced this issue May 13, 2021
@aladdin-add @ljharb
[Fix] no-unresolved: check import()
8789753 
Fixes import-js#2024.

refs: https://github.com/estree/estree/blob/master/es2020.md#importexpression
@ljharb ljharb mentioned this issue May 13, 2021
Merged
ljharb pushed a commit to aladdin-add/eslint-plugin-import that referenced this issue May 13, 2021
@aladdin-add @ljharb
[Fix] no-unresolved: check import()
794c50d 
Fixes import-js#2024.

refs: https://github.com/estree/estree/blob/master/es2020.md#importexpression
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 13, 2021
@aladdin-add
[Fix] no-unresolved: check import()
5be09ba 
Fixes import-js#2024.

refs: https://github.com/estree/estree/blob/master/es2020.md#importexpression
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 13, 2021
@aladdin-add
[Fix] no-unresolved: check import()
b7569a6 
Fixes import-js#2024.

refs: https://github.com/estree/estree/blob/master/es2020.md#importexpression
aladdin-add added a commit to aladdin-add/eslint-plugin-import that referenced this issue May 13, 2021
@aladdin-add
[Fix] no-unresolved: check import()
81f126a 
Fixes import-js#2024.

refs: https://github.com/estree/estree/blob/master/es2020.md#importexpression
@ljharb ljharb closed this as completed in 96ed3c7 May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] no-unresolved: check import() aladdin-add/eslint-plugin-import
2 participants
@ljharb @aladdin-add