Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document import/recommended #2032

Closed
edemaine opened this issue Apr 24, 2021 · 3 comments
Closed

Document import/recommended #2032

edemaine opened this issue Apr 24, 2021 · 3 comments

Comments

@edemaine
Copy link
Contributor

I learned about the ruleset import/recommended from reading the CHANGELOG, but it's not in the README. Presumably it should replace all the examples that use import/errors and import/warnings? (though those rulesets should also be mentioned once)

@ljharb
Copy link
Member

ljharb commented Apr 24, 2021

Unfortunately recommended rulesets in plugins aren’t often up to date with what’s recommended, because of semver constraints. It should be mentioned, but not encouraged.

@edemaine
Copy link
Contributor Author

@ljharb Is there a different source for "what's recommended"? I couldn't find anything in the documentation besides import/errors and import/warnings.

@ljharb
Copy link
Member

ljharb commented Apr 25, 2021

Not really, no - but I’d suggest the Airbnb config.

edemaine added a commit to edemaine/eslint-plugin-import that referenced this issue Apr 25, 2021
@ljharb ljharb closed this as completed in 7c1e8e4 May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants