Rule proposal: Enforce imports be placed at the top of the file

[sindresorhus]

Moved from jfmengels/eslint-plugin-import-order#11.

Imports are hoisted to the top anyways. So better to be explicit about it.

Should either ignore require or have an option to ignore it, as require is often used inline and is not hoisted.

[sindresorhus]

Sorry, I missed the imports-first rule...

[benmosher]

Do you envision this as an option on the order rule?

[benmosher]

Ah, lol, right. I also forgot that one. 😅

[benmosher]

I wouldn't be opposed to moving this into order. The existing rule is sort of a half-measure version of order anyway, could deprecate and drop the next time ESLint bumps major.

[sindresorhus]

I don't see how import-first is relevant to ordering though. It's just about enforcing imports at the top, in any order.

[benmosher]

I was thinking that if they are most frequently used together, it might be simpler to make it a single rule.

That's fair, though. Could move the opposite direction and take the absolute-first bit out of import-first, too.

On Apr 21, 2016, at 21:17, Sindre Sorhus <notifications@git.luolix.topmailto:notifications@github.com> wrote:

I don't see how import-first is relevant to ordering though. It's just about enforcing imports at the top, in any order.

You are receiving this because you commented.
Reply to this email directly or view it on GitHubhttps://github.com//issues/253#issuecomment-213195129

[sindresorhus]

Could move the opposite direction and take the absolute-first bit out of import-first, too.

👍 Agreed. It doesn't fit there.