Support eslint v9 #2948
Comments
|
Since we don’t even support flat config yet (#2873), and eslint doesn’t provide any replacement for FileEnumerator, I’d say it’ll probably be awhile before we support eslint 9. |
|
At least we can support using eslintrc on eslint v9 currently. TODO: compatible with some internal API migration like |
|
I'd definitely love to add some tests on eslint 9, using the env var that restores eslintrc, so we can get ahead of any needed changes. |
|
I made a patch for eslint-plugin-import@2.29.1 (and eslint-plugin-i@2.29.1) that works with pnpm and ESLint v9.0.0-beta.2: https://gist.github.com/TiagodePAlves/8c9b1ed4062a484022f5ebf7ba53a5d5 |
|
@TiagodePAlves thanks, that's helpful! once we have tests running on eslint 9, it shouldn't be too difficult to adapt that patch into something that works on both v9 and older versions. |
|
@ljharb fwiw I did a very naive find-and-replace of the Would you like me to attempt a draft PR? I don't know if I'll have the bandwidth to setup a whole test suite but I figure I can contribute enough to kick start the work 🙂 |
|
@G-Rath that might be the case! The blocker really is setting up tests, unfortunately - if we can get tests working on eslint 9, the rest is something I can probably find time for sooner than later :-) |
|
Amazing news on merging #2996 🎉 It’d be great to see a new release by the end of the week, because v8 reaches EOL on Saturday. At the time of writing, the latest release is v2.30.0 (2024-09-03). |
|
I'm traveling right now, but I should be able to get a release out before the end of the week. |
Which has implied, * Drop eslint-plugin-import in favor of eslint-plugin-import-x Since the eslint-plugin-import support for ESLint 9 is kind of a blocker for such an update at this moment. See import-js/eslint-plugin-import#2948 * Update eslint-plugin-react-hooks to an RC version For moving this update on without waiting until the support reach the @latest version. See facebook/react#30932 (comment) As commented at import-js/eslint-plugin-import#2948 (comment), > the ESLint plugin ecosystem is getting harder and harder to maintain, > and things get worse during major version upgrades.
Update web dependencies to their latest versions via `npm update` and `npm install package-name@latest` when needed. ## Additional notes * ESLint has been updated to the latest v9. To do so, _eslint-config-standard_ plugins were replaced by [_neostandard_](https://github.com/neostandard/neostandard). See agama-project@b447bc2 and agama-project@5433c00 * Now, the ESLint configuration lives at _eslint.config.mjs_. See ESLint migration guide https://eslint.org/docs/latest/use/migrate-to-9.0.0 * Linters check now (?) TypeScript files * A lot of linters complaints has been fixed. See commit by commit if interested. * **As a result of the migration, two icons were removed**. One of them was actually not in use. To know more see agama-project@a5c43a0 ### Special mention for agama-project@89214a7 As you can see in linked commit, the `useVolumeTemplates` query hook has changed significantly when fixing linters complaints. It was using a hook conditionally, breaking the `Do not call Hooks after a conditional return statement.` [rule of hooks](https://react.dev/reference/rules/rules-of-hooks). Although the change was done following the [TanStack Query documentation](https://tanstack.com/query/v5/docs/framework/react/guides/dependent-queries#usequeries-dependent-query), it has been manually tested too in order to check that everything works as expected when `useProductParams` returns `undefined`. And, apparently, it works: the `Add filesystem` button became disable. ## A quote > the ESLint plugin ecosystem is getting harder and harder to maintain, > and things get worse during major version upgrades — read in a [comment at eslint-pluign-import](import-js/eslint-plugin-import#2948 (comment)) --- Previous update: agama-project#1184
eslint-plugin-import doesn't support v9 yet, but there'll posibly be a release this week import-js/eslint-plugin-import#2948 (comment)
eslint-plugin-import doesn't support v9 yet, but there'll posibly be a release this week import-js/eslint-plugin-import#2948 (comment)
eslint-plugin-import doesn't support v9 yet, but there'll posibly be a release this week import-js/eslint-plugin-import#2948 (comment)
eslint-plugin-import doesn't support v9 yet, but there'll posibly be a release this week import-js/eslint-plugin-import#2948 (comment)
eslint-plugin-import doesn't support v9 yet, but there'll posibly be a release this week import-js/eslint-plugin-import#2948 (comment)
This is because eslint-plugin-import does not support ESLint v9. see: import-js/eslint-plugin-import#2948
Looks like the original author is no longer as interested in maintaining the plugin: import-js/eslint-plugin-import#2948 Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
It seems unused in our configuration, and i tested it by throwing an error in the index.js script. (And our imports don't seem to follow a structure). When import-js/eslint-plugin-import#2948 is resolved, we can think about adding it again. Allows ecamp#5155 for the frontend.
It seems unused in our configuration. When import-js/eslint-plugin-import#2948 is resolved, we can think about adding it again. Allows ecamp#5155 for aws-setup.
eslint 9 is being prepared and comes with a lot of changes impacting users and plugin developers: see https://eslint.org/blog/2023/12/eslint-v9.0.0-alpha.0-released/ for example.
What is the status of eslint v9 support for eslint-plugin-import?
The text was updated successfully, but these errors were encountered: