-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import/order incorrectly classifies linked in modules. #882
Labels
Comments
I have the same problem. |
.eslintrc: rules:
import/order:
- error
- groups: [builtin, external, internal, [sibling, index]]
newlines-between: always package.json: {
"dependencies": {
"@own-local/platform-dtd": "link:../platform-dtd"
}
} Code: import { injectIntl } from 'react-intl';
import type { Category, Business as BusinessType } from '@own-local/platform-dtd/lib/types'; Expected: no error Actual: |
Update: Looks like this is caused by the hyphen in our scoped module name: |
I don't have scoped modules.
…On Tue, Jul 25, 2017 at 11:03 AM Danny Andrews ***@***.***> wrote:
Update: Looks like this is caused by the hyphen in our scoped module name:
@own-local. This PR fixes the issue! #744
<#744>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#882 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjPrY50tFrxsr5NXFvjD-JUyckvGyZYks5sRhGzgaJpZM4OFrsv>
.
|
Ah, bummer, was hoping you had the same problem. Best of luck, mate! |
Closing because it's irrelevant now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have a project where I link in a library I'm working on at the same time as the app... the import/oder lint rules change based on linked state... even though the library's link is under node_modules.
The text was updated successfully, but these errors were encountered: