webpack resolver: cache instance(s) of resolve function #1091
Conversation
benmosher
changed the title
3 similar comments
resolvers/webpack/index.js
Outdated
| @@ -1,6 +1,6 @@ | |||
| var findRoot = require('find-root') | |||
| , path = require('path') | |||
| , get = require('lodash.get') | |||
| , _ = require('lodash') | |||
There was a problem hiding this comment.
i believe this should actually be get = require('lodash/get') for maximum tree-shake-ability, and for future compat with lodash 5.
There was a problem hiding this comment.
ooo cool, thanks. I have yet to get familiar with digging things directly out of lodash
resolvers/webpack/index.js
Outdated
| var _cache = [] | ||
| function getResolveSync(configPath, webpackConfig) { | ||
| var cacheKey = { configPath: configPath, webpackConfig: webpackConfig } | ||
| var cached = find(_cache, function (entry) { return _.isEqual(entry.key, cacheKey) }) |
There was a problem hiding this comment.
is there a reason to use an array here, rather than a Set, given that eslint only works on node 4+?
There was a problem hiding this comment.
you could arguably still use the latest webpack resolver with much older versions of ESLint and this plugin (at work I only just recently upgraded us from ESLint 2 and plugin v1).
I don't think it is critical to maintain the ES5, at this point, but I also didn't want to cross that bridge today if there wasn't a compelling reason. was easy enough to write this PR in ES5.
- also dropped webpack resolver support for node 0.10 (lol)
😅 _now_ it doesn't support 0.10.x anymore
ljharb
added
package: resolver/node
package: resolver/webpack
and removed
resolver
labels
5x speedup in resolver construction by caching the
resolveSyncif the webpack config+path matches.Fixes #788, AFAICT.
createResolveSyncfunction was responsible for 83% of the resolver setup time in my tests. After this PR, it is <10%. Went from >5s to ~250ms over a whole project.