Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-relative-parent-imports] support windows #1141

Merged
merged 1 commit into from
Sep 9, 2018
Merged

[no-relative-parent-imports] support windows #1141

merged 1 commit into from
Sep 9, 2018

Conversation

1pete
Copy link
Contributor

@1pete 1pete commented Jul 20, 2018

make rule no-relative-parent-imports support windows

as you see, appveyor ci failed in master branch, i think because windows uses \ as a directory delimiter
so i change path check to use regular expression [\\/]

@coveralls
Copy link

coveralls commented Jul 20, 2018

Coverage Status

Coverage remained the same at 97.284% when pulling 6920bb9 on 1pete:no-relative-parent-imports-windows into 5480240 on benmosher:master.

3 similar comments
@coveralls
Copy link

coveralls commented Jul 20, 2018

Coverage Status

Coverage remained the same at 97.284% when pulling 6920bb9 on 1pete:no-relative-parent-imports-windows into 5480240 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.284% when pulling 6920bb9 on 1pete:no-relative-parent-imports-windows into 5480240 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.284% when pulling 6920bb9 on 1pete:no-relative-parent-imports-windows into 5480240 on benmosher:master.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m confused; resolvers should be abstracting away things like “windows uses backslash” from us

@benmosher
Copy link
Member

@ljharb that is a great point but this PR implies we don't live in that universe--yet. 😄 fwiw I don't recall anything in any resolvers normalizing slashes. but that would be great to avoid stuff like this.

where "stuff like this" := intermittent AppVeyor gotchas.

thanks @1pete!

@benmosher benmosher merged commit e8954db into import-js:master Sep 9, 2018
@1pete 1pete deleted the no-relative-parent-imports-windows branch September 10, 2018 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants