Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExportMap] fix condition for checking if block comment #1234

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

ljqx
Copy link
Contributor

@ljqx ljqx commented Nov 16, 2018

This PR fixes #1233 .

Before the code uses \n as line ending to check if the comment is block comment. This PR changes to use comment.type which is more reliable.
https://github.com/benmosher/eslint-plugin-import/blob/798eed7e559adab2eac07bf1b3e3518d4b7a4296/src/ExportMap.js#L233

Tests are added for both \n and \r\n

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.36% when pulling 338508a on ljqx:export-map-fix-comment-condition into 798eed7 on benmosher:master.

@coveralls
Copy link

coveralls commented Nov 16, 2018

Coverage Status

Coverage remained the same at 97.865% when pulling e4850df on ljqx:export-map-fix-comment-condition into 918567d on benmosher:master.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks

@ljharb ljharb force-pushed the export-map-fix-comment-condition branch from e424e96 to e4850df Compare April 11, 2019 23:41
@ljharb ljharb merged commit e4850df into import-js:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Cannot parse @deprecated JSDoc on file with line ending \r\n
3 participants