Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export): Support typescript namespaces #1320

Merged
merged 1 commit into from
Apr 12, 2019
Merged

fix(export): Support typescript namespaces #1320

merged 1 commit into from
Apr 12, 2019

Conversation

bradzacher
Copy link
Contributor

Fixes #1300

  • Added nested export scope support
  • Fixed broken test on ESLint v3 caused by old typescript parser

@bradzacher bradzacher marked this pull request as ready for review April 12, 2019 17:27
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 97.981% when pulling 5a1db48 on bradzacher:export-ts-namespaces into 405900e on benmosher:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 97.981% when pulling 5a1db48 on bradzacher:export-ts-namespaces into 405900e on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 97.981% when pulling 5a1db48 on bradzacher:export-ts-namespaces into 405900e on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 97.981% when pulling 5a1db48 on bradzacher:export-ts-namespaces into 405900e on benmosher:master.

@coveralls
Copy link

coveralls commented Apr 12, 2019

Coverage Status

Coverage increased (+0.1%) to 97.981% when pulling 988e12b on bradzacher:export-ts-namespaces into 70c3679 on benmosher:master.

@ljharb
Copy link
Member

ljharb commented Apr 12, 2019

Hmm, I just pushed up a commit to deal with "Fixed broken test on ESLint v3 caused by old typescript parser" by skipping the test on eslint < 4. Does that mean this PR fixes the test so it passes? If so, please rebase and revert my change in the process :-)

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit 8a4226d into import-js:master Apr 12, 2019
@bradzacher
Copy link
Contributor Author

@ljharb - rebased on top!

Yeah the error was happening because in the old version of typescript which got installed with eslint v3 produced a different AST, hence that case wasn't handled. Not sure why it worked fine on the PR then failed on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

BUG? Typescript export namespace nested Multiple exports of name
3 participants