Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core]: regex marking packages as internal #1491

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

Librazy
Copy link
Contributor

@Librazy Librazy commented Sep 29, 2019

fixes #1125

We are developing packages in a monorepo and packages depend on each other so we need to separate our package from external dependency. We used to tslint/ordered-imports which allow custom group by regex pattern.

This PR added a new setting which allowed user to provide a regex pattern and packages that match that pattern will be marked internal.

@coveralls
Copy link

coveralls commented Sep 29, 2019

Coverage Status

Coverage decreased (-0.08%) to 96.183% when pulling c37e42f on Librazy:import-regex into 2cdfc19 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 96.135% when pulling 9b6def1 on Librazy:import-regex into 5e143b2 on benmosher:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 96.135% when pulling 9b6def1 on Librazy:import-regex into 5e143b2 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 96.135% when pulling 9b6def1 on Librazy:import-regex into 5e143b2 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 96.135% when pulling 9b6def1 on Librazy:import-regex into 5e143b2 on benmosher:master.

@Librazy Librazy changed the title [import/order]: regex marking packages as internal [core]: regex marking packages as internal Sep 29, 2019
@vincaslt
Copy link

Yes please, useful for monorepos, what's the plan for this?

@ljharb ljharb merged commit c37e42f into import-js:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

How to treat imports inside a monorepo as internal
4 participants