Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds compiler loading for to-js languages in a similar fashion to Webpack itself #164

Closed

Conversation

gausie
Copy link

@gausie gausie commented Feb 3, 2016

As mentioned in #102, this brings eslint-plugin-import in line with Webpack's own config loader.

@benmosher
Copy link
Member

Can you add tests?

I.E. an additional extra folder like https://github.com/benmosher/eslint-plugin-import/tree/master/resolvers/webpack/test/files/some with an ES6 config.

@gausie
Copy link
Author

gausie commented Feb 29, 2016

Sorry that I haven't been able to do this. If someone else is able to (@kentcdodds if you're looking into this also?) that would be great.

Otherwise hopefully I'll have some time this week

@kentcdodds
Copy link
Contributor

Sorry, decided that we're actually just going to be upgrading to Node4 this week anyway, so we're not going to be using the webpack.config.babel.js filename anymore anyway. Feel free to close #194.

benmosher added a commit that referenced this pull request Apr 27, 2016
@benmosher
Copy link
Member

agh, didn't realize this commit wasn't properly part of #278, would've rebased onto it for proper credit. that said, was just published as v0.2.2 of the webpack resolver and you're credited in the change log 😅

@benmosher benmosher closed this Apr 27, 2016
@gausie gausie deleted the feature/webpack-config-interpret branch April 27, 2016 12:02
@gausie
Copy link
Author

gausie commented Apr 27, 2016

@benmosher not a problem and thanks!

strawbrary pushed a commit to strawbrary/eslint-plugin-import that referenced this pull request Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants