Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to disable absolute-first option explicitly #1664

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

TheCrueltySage
Copy link
Contributor

Fixes #1661 .
Not sure if the alternative should be just an empty string or an explicit disable option. Went for the second for now.

@coveralls
Copy link

coveralls commented Feb 19, 2020

Coverage Status

Coverage increased (+0.04%) to 97.841% when pulling 1a3a128 on TheCrueltySage:master into efd6be1 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.839% when pulling 94e0c4b on TheCrueltySage:master into 12971f5 on benmosher:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.839% when pulling 94e0c4b on TheCrueltySage:master into 12971f5 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.839% when pulling 94e0c4b on TheCrueltySage:master into 12971f5 on benmosher:master.

@TheCrueltySage
Copy link
Contributor Author

Any news on this? It's literally a one-liner change.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me so long to review. We'd need test cases for this in order to accept it.

@TheCrueltySage
Copy link
Contributor Author

I don't have much experience in writing tests.
What do you mean by a test case here? As in, checking that absolute-first doesn't trigger with 'disable-absolute-first' option?

@TheCrueltySage
Copy link
Contributor Author

Something like this?

@TheCrueltySage
Copy link
Contributor Author

TheCrueltySage commented Mar 13, 2020 via email

@ljharb
Copy link
Member

ljharb commented Mar 13, 2020

Thanks, I think i get it now :-)

@TheCrueltySage
Copy link
Contributor Author

TheCrueltySage commented Mar 13, 2020 via email

@ljharb
Copy link
Member

ljharb commented Mar 13, 2020

This one's good; an empty string is super confusing.

@ljharb ljharb merged commit 1a3a128 into import-js:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[import/first] Impossible to turn off absolute-import from dervied config
3 participants