Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] group-exports: Flow type export awareness #1707

Merged
merged 1 commit into from
Apr 7, 2020
Merged

[Fix] group-exports: Flow type export awareness #1707

merged 1 commit into from
Apr 7, 2020

Conversation

ernestostifano
Copy link
Contributor

Fix for [#1702].

Now export and export type statements are handled separately with the same logic.

@coveralls
Copy link

coveralls commented Mar 29, 2020

Coverage Status

Coverage increased (+0.007%) to 97.804% when pulling baf1a8c on ernestostifano:feature/issue-1702 into 6a110dd on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 97.804% when pulling 4207cba on ernestostifano:feature/issue-1702 into 71ca88f on benmosher:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 97.804% when pulling 4207cba on ernestostifano:feature/issue-1702 into 71ca88f on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 97.804% when pulling 4207cba on ernestostifano:feature/issue-1702 into 71ca88f on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 97.804% when pulling 4207cba on ernestostifano:feature/issue-1702 into 71ca88f on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 97.804% when pulling 4207cba on ernestostifano:feature/issue-1702 into 71ca88f on benmosher:master.

@ernestostifano
Copy link
Contributor Author

Note: If .idea files shall be kept, then .idea/codeStyles/Project.xml and .idea/inspectionProfiles/Project_Default.xml can be adjusted to match project rules. If not, then .gitignore changes can be reverted and the whole .idea directory can be deleted.

@ernestostifano
Copy link
Contributor Author

I will close this pull request and make a new one with a simpler commit history. Current commits have wrong author data (Sourcetree messed up).

@ernestostifano ernestostifano deleted the feature/issue-1702 branch April 5, 2020 22:51
@ljharb
Copy link
Member

ljharb commented Apr 5, 2020

Please do not do that - please restore the branch and reopen this PR.

@ljharb
Copy link
Member

ljharb commented Apr 5, 2020

I can help you rebase this one, but a new PR makes clutter i can never ever clean up.

@ernestostifano
Copy link
Contributor Author

I tried several ways to amend commits author data with no success. Should I restore the deleted forked repository? Can I fork it again and point this pull request to a new branch? I have saved all the changes I made, so no work is lost. Please let me know.

@ljharb
Copy link
Member

ljharb commented Apr 6, 2020

Ah, if you deleted the fork, then that’s unrecoverable. In the future, please don’t delete a fork with an unmerged PR.

Maintainers can always clean up the branch before merging.

@ernestostifano
Copy link
Contributor Author

I am sorry if I did wrong. Lesson learned. Should I create a new PR with the issue fix?

@ernestostifano ernestostifano restored the feature/issue-1702 branch April 6, 2020 14:46
@ernestostifano ernestostifano reopened this Apr 6, 2020
@ernestostifano
Copy link
Contributor Author

@ljharb wrote to GitHub. Everything is restored. When you have time, we can clean up commits.

@ernestostifano
Copy link
Contributor Author

Why have coverage decreased if it was increased before? Also why are not all checks passing now?

@golopot
Copy link
Contributor

golopot commented Apr 6, 2020

Some tests are skipped in older eslint versions. CI jobs with older eslint report lower coverage. Therefore sometimes coveralls reports decreased coverage randomly.

@ljharb
Copy link
Member

ljharb commented Apr 7, 2020

@ernestostifano thank you! I've rebased it, and removed the .idea stuff which belongs in your personal global gitignore, and not in every project you happen to touch. I'll review soon.

@ljharb ljharb changed the title Issue #1702 fix [Fix] group-exports: Flow type export awareness Apr 7, 2020
@ernestostifano

This comment has been minimized.

@ljharb

This comment has been minimized.

@ljharb ljharb merged commit baf1a8c into import-js:master Apr 7, 2020
@ernestostifano ernestostifano deleted the feature/issue-1702 branch April 7, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants