-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] group-exports
: Flow type export awareness
#1707
Conversation
4 similar comments
Note: If |
I will close this pull request and make a new one with a simpler commit history. Current commits have wrong author data (Sourcetree messed up). |
Please do not do that - please restore the branch and reopen this PR. |
I can help you rebase this one, but a new PR makes clutter i can never ever clean up. |
I tried several ways to amend commits author data with no success. Should I restore the deleted forked repository? Can I fork it again and point this pull request to a new branch? I have saved all the changes I made, so no work is lost. Please let me know. |
Ah, if you deleted the fork, then that’s unrecoverable. In the future, please don’t delete a fork with an unmerged PR. Maintainers can always clean up the branch before merging. |
I am sorry if I did wrong. Lesson learned. Should I create a new PR with the issue fix? |
@ljharb wrote to GitHub. Everything is restored. When you have time, we can clean up commits. |
Why have coverage decreased if it was increased before? Also why are not all checks passing now? |
Some tests are skipped in older eslint versions. CI jobs with older eslint report lower coverage. Therefore sometimes coveralls reports decreased coverage randomly. |
@ernestostifano thank you! I've rebased it, and removed the |
group-exports
: Flow type export awareness
Fix for [#1702].
Now
export
andexport type
statements are handled separately with the same logic.