-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fixing typo in IDE section #1744
Conversation
2 similar comments
Can you provide a test case, that would have prevented this from happening? |
I wanted, but I haven't found any similar cases in tests. It requires a big work to achieve this. If I understand right test cases covers rules but don't covers IDE integrations. I test this by running two files in row:
It fails when I run like this:
But pass if run in opposite direction:
I don't sure that I can reproduce this behaviour in tests |
Maybe I'm a bit confused; #1743 doesn't have much background. It shouldn't be possible for an IDE integration to do anything different than is done on the command line; if something works on the CLI but breaks in an IDE, the IDE itself is broken, full stop. |
Please take a look to update of my previous message |
Interesting, thanks - I'd bet you could add that setup inside https://github.com/benmosher/eslint-plugin-import/tree/master/tests/files, and that might lead to reproducing it? |
I can try, but how I can run two files in row in test? |
It was easier then I thought. My example was wrong a bit. This is right example:
|
I have found another case and fixed it too but I think this function have even more issues. |
@ljharb what else can I do to merge this? |
Fixes #1743