[Tests] extensions: add cases to verify @/configs/chart is treated as a package
#1925
Conversation
…d as a package See import-js#1851.
wenfangdu
changed the title
@/configs/chart being treated as a package.
tests/src/rules/extensions.js
Outdated
| @@ -367,6 +368,11 @@ ruleTester.run('extensions', rule, { | |||
| line: 4, | |||
| column: 31, | |||
| }, | |||
| { | |||
| message: 'Missing file extension for "@/configs/chart"', | |||
There was a problem hiding this comment.
again tho, this should never have a warning when ignorePackages is set, because it's a bare idenfier - a package.
There was a problem hiding this comment.
According to the scoped packages doc, @somescope/somepackagename is a scoped package, whereas @/foo/bar is not. Publishing @/foo/bar as an unscoped package is also not allowed, so it's neither a scoped package nor an unscoped package, therefore not a package.
There was a problem hiding this comment.
I agree that it isn't "a scoped package", but since it doesn't start with . or /, it is a "bare identifier", which is always "a package" - packages aren't just "publishable packages", they're "anything with a bare identifier".
There was a problem hiding this comment.
Circling back on this - @ is a package here (just not a publishable one), so I think this should be ignored when ignorePackages is enabled.
tests/src/rules/extensions.js
Outdated
| @@ -367,6 +368,11 @@ ruleTester.run('extensions', rule, { | |||
| line: 4, | |||
| column: 31, | |||
| }, | |||
| { | |||
| message: 'Missing file extension for "@/configs/chart"', | |||
There was a problem hiding this comment.
Circling back on this - @ is a package here (just not a publishable one), so I think this should be ignored when ignorePackages is enabled.
ljharb
changed the title
@/configs/chart being treated as a package.extensions: add cases to verify @/configs/chart is treated as a package
Fixes #1851
Before this fix,
'import/extensions': ['warn', 'ignorePackages']wouldn't warnimport chart from '@/configs/chart', this is an improvement over PR #1854.