[Refactor] importType: use is-core-module instead of resolve/lib/core
#1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JLHwung thanks; the deprecation warning has been removed in resolve v1.18.1, so this should be "fixed" for you, but this change is still a good idea. |
ljharb
approved these changes
Oct 19, 2020
ljharb
force-pushed
the
resolve-lib-core-is-deprecated
branch
from
3dde3f2 to
ccd4ccc
Compare
ljharb
approved these changes
Oct 19, 2020
ljharb
changed the title
resolve/lib/core by is-core-moduleimportType: use is-core-module instead of resolve/lib/core
ljharb
force-pushed
the
resolve-lib-core-is-deprecated
branch
from
ccd4ccc to
5e1baf3
Compare
ljharb
force-pushed
the
resolve-lib-core-is-deprecated
branch
from
5e1baf3 to
13aa29c
Compare
ljharb
reviewed
Apr 28, 2021
| @@ -105,6 +105,7 @@ | |||
| "eslint-import-resolver-node": "^0.3.4", | |||
| "eslint-module-utils": "^2.6.0", | |||
| "has": "^1.0.3", | |||
| "is-core-module": "^1.0.2", | |||
There was a problem hiding this comment.
oops, this should have been v2, not v1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
resolve/lib/corebyis-core-moduleis suggested in browserify/resolve@1222da1context: Babel e2e test is failing because
resolve/lib/coreis deprecated: https://app.circleci.com/pipelines/github/babel/babel/4244/workflows/de314db0-9b52-44c8-b6a5-9ca7d4b2cfd6/jobs/30580/cc @ljharb