Core package #234
Closed
Core package #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| if (modulePath.type !== 'Literal') return | ||
| if (typeof modulePath.value !== 'string') return | ||
|
|
||
| checkSourceValue(modulePath) |
There was a problem hiding this comment.
This function would also apply for require function calls when require is shadowed. So I think it would make sense to also check the scope where the reference come from.
There was a problem hiding this comment.
Makes sense, I'll add a note.
Hadn't run into it so far, and that is part of why it checks the argument count and argument type (also to disambiguate from AMD require)
|
Superseded by #408! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull out
src/coreintoeslint-module-utils, to be published separately for other plugins to leverage.Also, a bunch of v2 things.
(closes #233)
hashto tiny module and/or find existing (object-hash,hash-object)dependencieseslint-plugin-gitfor no-unstaged #198babel-preset-argondoctrinedependency (either declare or pull out to import plugin, or extractExportMapto third module?)