Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] named/ExportMap: handle named imports from CJS modules that use dynamic import #2341

Merged
merged 1 commit into from
Jan 1, 2022

Commits on Dec 30, 2021

  1. [Fix] named/ExportMap: handle named imports from CJS modules that…

    … use dynamic import
    
    Fix import-js#2294
    
    Mark ambiguous (i.e. not unambiguously ESM) modules that contain dynamic import()
    so that they can be ignored like other ambiguous modules when analysing named imports.
    
    In this way, the named rule accepts named imports from CJS modules that contain
    dynamic imports.
    
    Also fix the case where the importing module uses a require() call.
    ludofischer authored and ljharb committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    e3ca68e View commit details
    Browse the repository at this point in the history