Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make imports-first treat directives as an exception #256

Merged

Conversation

lemonmade
Copy link
Contributor

Fixes #255. Per discussion in that issue, directives need to appear at the top of a file in order to be considered directives. This isn't usually a problem because modules remove the need for 'use strict', but we use a custom directive as part of our build system. This PR makes imports-first understand directives and not throw errors when those appear above import statements.

cc/ @benmosher, let me know if anything else is needed; I didn't see a contributing file in the repo so not sure what the best practices are.

@benmosher benmosher merged commit f3e0581 into import-js:master Apr 22, 2016
benmosher added a commit that referenced this pull request Apr 22, 2016
@benmosher
Copy link
Member

Just tacked a note into the changelog.

Duly noted about a contribution guide, just opened #258 to that end 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants