-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] no-duplicates with type imports #2716
base: main
Are you sure you want to change the base?
Conversation
ab7a2d8
to
d2292bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and so on, all the loops should be iteration methods whenever possible :-)
Am I correct this would fix #2675 ? If so this is my new favourite PR. 😄 If you need any testing done, I can probably help. |
Is there a reason for this guidance? |
@runspired loops make code harder to understand and reason about. It's explained in the airbnb styleguide as well. |
3025495
to
9abf816
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look forward to the other 2 fixes :-)
@ljharb @snewcomer I am very interested in these fixes, so I wanted to take a stab at the remaining TODO items. As it turns out, they were already covered by this PR! I reorganised some tests (inspired by Test results
|
Hey, it would be great to handle type imports with |
Is there anything else we can help with to get this merged? It's a great improvement over the current behaviour. |
Also eager to see this merged and happy to help where needed! |
@snewcomer Hi! Sorry for mention, but this PR is super helpfull and it will be great to see this merged! Are there any additional things you would like to work on? |
I havent tested yet, but this might be fixed by #2835 |
I've rebased this PR, but tests seem to be failing. @mrm007 sorry i hadn't looked at your PR-PR yet - would you mind rebasing yours, and then I can pull it in? |
a987e22
to
bfdb9d0
Compare
@snewcomer is there a reason you overwrote my rebase? |
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
bfdb9d0
to
864effb
Compare
Hi sorry. I didn't see any commits. If I was mistaken due to keeping this PR open in Safari and not getting real time updates, I'm sorry. FYI put a comment here. |
Follow up fixes to #2475
Ref bug PRs:
{"prefer-inline": true}
does not work #2715no-duplicates
when using Flow. #2691