Support Node v6

[benmosher]

Track progress against this PR.

Known issues:

• Node.js v6: Can't pass null to path module functions #272: don't pass null to path functions

[strawbrary]

v6 is on Travis now so you should be good to retry.

I haven't encountered any issues on v6 besides the null path one.

[jfmengels]

I re-ran the tests, and it's good to go :)

[benmosher]

Interesting, if no tests are failing, that means there is no test that covers #272? Which seems weird, I would think at least one test would try to resolve a builtin.

So feels like we need at least one test for that breaks a la #272 before merging? (after fixing it, too)

[strawbrary]

Hmm that is strange. On my local box I get 36 failures when running on v6.0.0. Could someone else try it and see if they get the same?

[jfmengels]

It passes all tests on my machine (removed node_modules, npm ied and npm test) 😕

[benmosher]

@strawbrary are you on Windows? or OSX?
@jfmengels: same question?

I just added v6 to the Appveyor config to see how Windows takes it.

[jfmengels]

Linux Ubuntu here.

[strawbrary]

OSX El Capitan

[strawbrary]

It seems like fileExistsWithCaseSync is never called with a null filepath under Linux, while it is under OSX and Windows since they are case insensitive. So it looks like only AppVeyor will be able to catch this issue.

[benmosher]

Yep, that makes sense. I'm on OSX but haven't tried to run locally yet.

[Salakar]

Tested on OSX + node v6, all good.

(also resolves Webstorm's Cannot parse checkstyle XML error - for those finding this error randomly lurking up on them 😆 )

LGTM