Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Revert breaking group change in order #2854

Merged
merged 1 commit into from
Aug 18, 2023
Merged

[Fix] Revert breaking group change in order #2854

merged 1 commit into from
Aug 18, 2023

Commits on Aug 9, 2023

  1. Revert 1fa2971 (breaking group change in order)

    1fa2971 changed the way groups work when there is only one, leading
    to single nested groups being treated as though they were unnested.
    Prior to this, if you wanted to group e.g. builtin and external
    imports together at the top and everything else together as a second
    group, a single nested group was the way to do it
    
    [It appears that this change was unintentional][1], and was made to
    try to fix what seems to be a misunderstanding around nested groups
    ([#2687]). [The docs][2] continue to suggest that nested groups
    should be "mingled together" and makes no reference to a single nested
    group with no other groups being an invalid option
    
    This therefore reverts the change to how groups work when there is
    only one. No documentation change should be necessary given this is
    already the described behaviour
    
    [1]: #2687 (comment)
    [2]: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/order.md#groups-array
    yndajas authored and ljharb committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    0847443 View commit details
    Browse the repository at this point in the history