-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-mutable-exports #290
Closed
Closed
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
48bdc81
Add no-mutable-exports
josh 0d2a4ef
Fix tabs
josh 4c35830
Quote const
josh 16f539e
Add no-mutable-exports to CHANGELOG
josh 09ec4de
Add no-mutable-exports to helpful warnings
josh 4d161b5
Merge remote-tracking branch 'origin/master' into no-mutable-exports
josh ef07a5e
Fix expected quotes around 'const'
josh 129d5d2
Add detection for null export declarations
josh 47bf05e
Remove merge conflict line
josh 69a1fb6
Implement no mutable exports for default exports
josh f5dbb77
Merge remote-tracking branch 'origin/master' into no-mutable-exports
josh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# no-mutable-exports | ||
|
||
Forbids the use of mutable exports with `var` or `let`. | ||
|
||
## Rule Details | ||
|
||
Valid: | ||
|
||
```js | ||
export const count = 1 | ||
export function getCount() {} | ||
``` | ||
|
||
...whereas here exports will be reported: | ||
|
||
```js | ||
export let count = 2 | ||
export var count = 3 | ||
``` | ||
|
||
## When Not To Use It | ||
|
||
If your environment correctly implements mutable export bindings. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
module.exports = function (context) { | ||
return { | ||
'ExportNamedDeclaration': function (node) { | ||
const kind = node.declaration.kind | ||
if (kind === 'var' || kind === 'let') { | ||
context.report(node, `Exporting mutable '${kind}' binding, use const instead.`) | ||
} | ||
}, | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import {test} from '../utils' | ||
import {RuleTester} from 'eslint' | ||
import rule from 'rules/no-mutable-exports' | ||
|
||
const ruleTester = new RuleTester() | ||
|
||
ruleTester.run('no-mutable-exports', rule, { | ||
valid: [ | ||
test({ code: 'export const count = 1'}), | ||
test({ code: 'export function getCount() {}'}), | ||
test({ code: 'export class Counter {}'}), | ||
], | ||
invalid: [ | ||
test({ | ||
code: 'export let count = 1', | ||
errors: ['Exporting mutable \'let\' binding, use const instead.'], | ||
}), | ||
test({ | ||
code: 'export var count = 1', | ||
errors: ['Exporting mutable \'var\' binding, use const instead.'], | ||
}), | ||
], | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, could you wrap
const
in quotes too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some odd indentation here, do you mind fixing it?