Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ESLint v9 #2996
base: main
Are you sure you want to change the base?
feat: support ESLint v9 #2996
Changes from 13 commits
c5e1837
7d87667
fafff19
0bced7c
cf9e418
0b0e4a1
a0957a5
97f2969
5902437
b3af57c
eb520f6
51e05e1
f3318fb
9264f4d
a99a391
f1e7cd2
727839a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 3 in src/context.js
src/context.js#L3
Check warning on line 19 in src/context.js
src/context.js#L19
Check warning on line 29 in src/context.js
src/context.js#L29
Check warning on line 39 in src/context.js
src/context.js#L39
Check warning on line 49 in src/context.js
src/context.js#L49
Check warning on line 125 in src/rules/named.js
src/rules/named.js#L125
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the scope is for the program, i think, so it should be gotten without the node, or with the entire program's node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, I'll try passing in the program node and see what happens