Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-mutable-exports: Handle ES7 export extensions. Fixes #317 #322

Merged
merged 1 commit into from
May 9, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rules/no-mutable-exports.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ module.exports = function (context) {

if (node.declaration) {
checkDeclaration(node.declaration)
} else {
} else if (!node.source) {
for (let specifier of node.specifiers) {
checkDeclarationsInScope(scope, specifier.local.name)
}
Expand Down
4 changes: 4 additions & 0 deletions tests/src/rules/no-mutable-exports.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ ruleTester.run('no-mutable-exports', rule, {
test({ code: 'class Counter {}\nexport { Counter as Count }'}),
test({ code: 'class Counter {}\nexport default Counter'}),
test({ code: 'class Counter {}\nexport { Counter as default }'}),
test({
parser: 'babel-eslint',
code: 'export Something from "./something";',
}),
],
invalid: [
test({
Expand Down