Fix order's newlines-between edge cases
#339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2016 23:49
to be at least one, not exactly one Before it was 1. To prevent multiple lines between imports, core `no-multiple-empty-lines` rule can be used.
singles
changed the title
newlines-between edge cases
| @@ -110,28 +110,33 @@ function convertGroupsToRanks(groups) { | |||
| } | |||
|
|
|||
| function makeNewlinesBetweenReport (context, imported, newlinesBetweenImports) { | |||
| const getLineDifference = (currentImport, previousImport) => { | |||
| return currentImport.node.loc.start.line - previousImport.node.loc.start.line | |||
| const getNumberOfEmptyLinesBeetwen = (currentImport, previousImport) => { | |||
added 2 commits
May 14, 2016 09:24
Previously it was calculated based on `loc` property of nodes. Counting REAL empty lines is less error-prone.
|
LGTM, thanks @singles :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all issues mentioned in #313:
requireused inside objects are ignored.It also changes requirement - there's no specific limit about 1 empty line between groups. Now it has to be at least 1. If one would like to have only one, then
no-multiple-empty-linescore rule can be used (thx @lo1tuma for hint!).I'm not 100% sure about implementation for last one - it works for provided test cases, yet I could use another pair of eyes.