allow multiple named export through variable deconstructing fixes #342 #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,8 @@ | |||
| 'use strict' | |||
|
|
|||
| import get from 'lodash.get' | |||
| // import forEach from 'lodash.forEach' | |||
There was a problem hiding this comment.
You missed removing a comment here :)
|
Not that familiar with this export syntax so I don't know if there are caveats, but LGTM (once the extra comment has been removed 😄). Thanks @gavriguy! |
|
Oops didn't see the progress that was made - I'll hold off in favor of #343. @scottnonnenberg feel free to take anything from this PR. and please let me know if you need any help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #342 by allowing to export more than one variable using variable deconstructing