Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#609) Make prefer-default-export count re-exported default exports #622

Merged
merged 1 commit into from
Oct 12, 2016

Conversation

jfmengels
Copy link
Collaborator

(#609) Make prefer-default-export count re-exported default exports

The rule didn't count re-exporting default exports, which led to it reporting where it shouldn't have.

I also moved out the captureDeclaration function declaration because I easily could and so that it wouldn't get re-declared for every encountered ExportNamedDeclaration.

@coveralls
Copy link

coveralls commented Oct 12, 2016

Coverage Status

Coverage increased (+0.003%) to 94.896% when pulling f9faaad on issue-609 into 2b7e64f on master.

@benmosher
Copy link
Member

Oh cool, already fixed! Thanks!

@benmosher benmosher merged commit c787026 into master Oct 12, 2016
@jfmengels jfmengels deleted the issue-609 branch October 12, 2016 19:29
@jfmengels
Copy link
Collaborator Author

ineedthisforreactions-youre-welcome-gif-wl8OeD1gqUe4M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants