Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] no-extraneous-dependencies: check both the absolute and relative filename #630

Merged
merged 1 commit into from
Nov 2, 2016
Merged

[New] no-extraneous-dependencies: check both the absolute and relative filename #630

merged 1 commit into from
Nov 2, 2016

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Oct 18, 2016 •
edited
Loading

Fixes #602.

This should be semver-minor.

@ljharb ljharb mentioned this pull request Oct 18, 2016
Closed
@coveralls
Copy link

coveralls commented Oct 18, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 94.899% when pulling 2ba174d on ljharb:use_cwd into d9605a0 on benmosher:master.

jfmengels
jfmengels approved these changes Oct 18, 2016
View reviewed changes
Copy link
Collaborator

@jfmengels jfmengels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ljharb!

@ljharb
Copy link
Member Author

ljharb commented Oct 19, 2016

@benmosher i'd love to see this merged and released! :-D

@ljharb
Copy link
Member Author

ljharb commented Oct 20, 2016

@jfmengels any chance you could do the honors? :-)

@jfmengels
Copy link
Collaborator

I still don't know the release process, sorry :/
Try DMing @benmosher on Twitter maybe.

Would gladly do it next time though ^^'

@coveralls
Copy link

coveralls commented Oct 22, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 94.899% when pulling d900e2b on ljharb:use_cwd into 2cbd801 on benmosher:master.

ljharb referenced this pull request in airbnb/javascript Oct 26, 2016
@ljharb
[eslint config] [deps] [breaking] update eslint-config-airbnb-base,…
0bb3eb5 
… `eslint-plugin-import`
@ljharb ljharb force-pushed the use_cwd branch 2 times, most recently from ef1d180 to 3262aba Compare October 27, 2016 02:28
@coveralls
Copy link

coveralls commented Oct 27, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 94.907% when pulling 3262aba on ljharb:use_cwd into edbb570 on benmosher:master.

@coveralls
Copy link

coveralls commented Oct 27, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 94.907% when pulling 3262aba on ljharb:use_cwd into edbb570 on benmosher:master.

@ljharb ljharb mentioned this pull request Oct 27, 2016
Closed
@benmosher benmosher merged commit 3262aba into import-js:master Nov 2, 2016
@ljharb ljharb deleted the use_cwd branch November 2, 2016 16:16
This was referenced Apr 15, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfmengels jfmengels jfmengels approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ljharb @coveralls @jfmengels @benmosher