Performance increase for no-absolute-path #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2017 18:37
importTypes helper performs resolve() - which does not look needed for the no-absolute-path rule. Additionally, the absolute condition only seems like it was used for no-absolute-path. Finally, all the tests continue to pass.
The old name seems wrong. Probably copied from no-extraneuous-dependencies
|
@benmosher, what do you think of this change? If it's not useful/needed, then I will close the PR. Thanks! |
benmosher
requested changes
Jun 28, 2017
| @@ -8,10 +8,6 @@ function constant(value) { | |||
| return () => value | |||
| } | |||
|
|
|||
| function isAbsolute(name) { | |||
There was a problem hiding this comment.
instead of removing this, could you export it and then import it in no-absolute-path?
| @@ -50,7 +46,6 @@ function isRelativeToSibling(name) { | |||
| } | |||
|
|
|||
| const typeTest = cond([ | |||
| [isAbsolute, constant('absolute')], | |||
There was a problem hiding this comment.
also keep this here, needed for import/order AFAIK
| context.report(node, 'Do not import modules using an absolute path') | ||
| } | ||
| } | ||
|
|
||
| function isAbsolute(name) { |
There was a problem hiding this comment.
so this is replaced with import { isAbsolute } from '../core/importType'
| @@ -8,12 +8,6 @@ import { testContext } from '../utils' | |||
| describe('importType(name)', function () { | |||
| const context = testContext() | |||
|
|
|||
| it("should return 'absolute' for paths starting with a /", function() { | |||
There was a problem hiding this comment.
and then put these tests back 😁
benmosher
added a commit
that referenced
this pull request
Jul 6, 2017
This was referenced Jul 6, 2017
|
@benmosher I missed your comments. Do you still want to make the suggested refactoring or was it done in another PR/commit? Sorry - been a bit busy due to holidays and other priorities - and somehow I completely missed your messages. |
SpainTrain
pushed a commit
to SpainTrain/eslint-plugin-import
that referenced
this pull request
Aug 2, 2017
* origin/master: (66 commits) [Fix] unescape unnecessarily escaped regex slashes [Dev Deps] dev dep ranges should match peer dep ranges docs(readme): add space (import-js#888) bump to v2.7.0 changelog note for import-js#843 upgraded no-absolute-path to use `moduleVisitor` pattern to support all module systems PR note fixes bump to v2.6.1 to bump dep on node resolver to latest 😳 Update no-extraneous-dependencies.md (import-js#878) Fix flow interface imports giving false-negative with `named` rule bump to 2.6.0, node/0.3.1, webpack/0.8.3, memo-parser/0.2.0 chore(eslint): upgrade to eslint@4 memo-parser: require eslint >= 3.5.0 (need file path always) build on node v4, again (import-js#855) bump to v2.5.0 bump `debug` version everywhere resolvers/webpack: v0.8.2 eslint-module-utils: v2.1.1 (bumping to re-publish to npm) [Tests] comment out failing (and probably invalid) test Only apps should have lockfiles. ...
This was referenced Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my reply here for a detailed analysis on why I made this change: #803 (comment)
I remove the call to
resolve()inno-absolute-pathrule. That should make this rule faster when it is used as a standalone rule or with other rules that are not dependent on having to resolve file paths.As I currently see no reason to have to call
resolve()for this rule at all. However, I am new to the code, so I may be wrong. :)