Add no-commonjs-exports-with-import rule #902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to start using Webpack to resolve imports instead of Babel. One key difference is that Webpack will break the bundle if you use `import` in the same file that `module.exports` is used, but it will appear to build pretty alright. When this happens, webpack outputs a warning like: ``` WARNING in ./foo.js 4:12-13 "export 'default' (imported as 'bar') was not found in './bar' ``` And when the JS is run in the browser, an error like the following is logged: ``` Uncaught TypeError: Cannot assign to read only property 'exports' of object '#<Object>' ``` To make this safer to turn on, I am adding this no-commonjs-exports-with-import rule which reports when it encounters an `import` in the same file as a CommonJS `module.exports` or `exports.*`.
|
This might be a duplicate of #804. |
1 similar comment
|
#804 is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to start using Webpack to resolve imports instead of Babel. One
key difference is that Webpack will break the bundle if you use
importin the same file that
module.exportsis used, but it will appear tobuild pretty alright. When this happens, webpack outputs a warning like:
And when the JS is run in the browser, an error like the following is
logged:
To make this safer to turn on, I am adding this
no-commonjs-exports-with-import rule which reports when it encounters an
importin the same file as a CommonJSmodule.exportsorexports.*.