Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long while I have been using
mobc 0.5
becausemobc 0.6
would always fail to compile with this error:However, the crate builds fine when you clone it and build. So what's the deal? Turns out if you have a crate as a dependency and a dev-dependency, it will include the
features
for the crate from both builds. See here: rust-lang/cargo#7915Since dev-dependencies aren't included when using the crate as a library, we were left with only the features specified in the
[dependencies]
section.Well, starting in
tokio 0.3
(and1.0
for that matter) callingRuntime::new
directly requires thert-multi-thread
feature:https://docs.rs/tokio/1.0.1/tokio/runtime/struct.Runtime.html#method.new
This issue is fixed in this PR by adding the required feature.
Closes: #48