Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl debug for Pool struc #84

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

pjb157
Copy link
Contributor

@pjb157 pjb157 commented Sep 26, 2023

Simple functionality to add some debug impl to structs I am using in a personal project. Don't need any particular detail but just these structs to have a debug impl.

@pjb157 pjb157 mentioned this pull request Sep 26, 2023
Copy link
Collaborator

@garrensmith garrensmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick test and from what I can see you only need:

impl<M: Manager> fmt::Debug for Pool<M> {

Could you remove the other two derive debug and then this is good to go.

@garrensmith garrensmith merged commit c90f2ae into importcjj:main Sep 27, 2023
1 check passed
@garrensmith
Copy link
Collaborator

Awesome. Thanks for the contribution

@garrensmith
Copy link
Collaborator

Latest release is out with this fix https://github.com/importcjj/mobc/releases/tag/0.8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants