feature: Add Form Extension #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feature: add block placeholder and notice * feature: add window declaration * refactor: remove inline window declaration, update list and tag options, use new placeholder and notice * refactor: use credential test prior to api calls, add method for tags, update localized script. * feature: add credential test prior to adding new block * refactor: replace blocknotice * refactor; reformat, update strings. * refactor: reformat remove spaces in src/FormExtension/Actions/EnqueueFormBuilderScripts.php * doc: update unreleased tags * doc: update unreleased tags * refactor: replace relative url path with admin_url for better WP support
* feature: add block placeholder and notice * feature: add window declaration * refactor: remove inline window declaration, update list and tag options, use new placeholder and notice * refactor: use credential test prior to api calls, add method for tags, update localized script. * feature: add credential test prior to adding new block * refactor: replace blocknotice * refactor; reformat, update strings. * refactor: reformat remove spaces in src/FormExtension/Actions/EnqueueFormBuilderScripts.php * doc: update unreleased tags * doc: update unreleased tags * refactor: replace relative url path with admin_url for better WP support * refactor: update template styles for consistency * refactor: reformat * refactor: update & export window types * feature: add tag & list controls. Split InspectorControls into new directory * refactor: use update inspectorControls * chore: remove debug log * chore: formatting * refactor: add ending bracket * refactor: update metadata default label * refactor: update template defaultChecked prop to checkeda * refactor: replace selectedEmailList attribute to selectedLists * refactor: update list control label * refactor: fix translation domain on subscriber tags * refactor: update listControl to always have one list selected * refactor: use array fallback on selectedLists * refactor: update domain names * refactor: return early on methods requiring credential tests * Refactor: use early return on add block to new form * refactor: fix double negative conditonal * refactor: update conditionals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a form extension for v3 compatibility.
Related:
Refactor: ActiveCampaign has block requirements #5
Refactor: block design improvements #6
Visuals
Testing Instructions