Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update settings url for activation banner #7

Merged
merged 1 commit into from
May 2, 2024
Merged

refactor: update settings url for activation banner #7

merged 1 commit into from
May 2, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Apr 28, 2024 •
edited
Loading

Resolves GIVE-443

Description

This PR updates the URL path that the ActiveCampaign activation banner uses for the settings page.

Affects

Visuals

Screen.Recording.2024-04-28.at.3.57.20.PM.mov

Testing Instructions

  • Install Active Campaign
  • Toward the top of the plugins page is an activation banner. Within the banner their is a link for the settings page. Verify that link works as expected.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh changed the title refactor: update settings url on activation banner refactor: update settings url for activation banner Apr 28, 2024
@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review April 28, 2024 23:12
pauloiankoski
pauloiankoski approved these changes May 1, 2024
View reviewed changes
Copy link

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rickalday
rickalday approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@JoshuaHungDinh JoshuaHungDinh merged commit e656183 into develop May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloiankoski pauloiankoski pauloiankoski approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaHungDinh @rickalday @pauloiankoski