refactor: validate array prior to adding tags on v2 forms #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-776
Description
This PR addresses a fatal error thrown on v2 forms when users customize per form settings and do not include tags. This is done by casting
$tagsas an array to handle empty string values from being imploded.The error is thrown due to an array method
implodebeing called on an empty string value.Affects
Visuals
Screen.Recording.2024-05-13.at.10.30.34.AM.mov
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks