Set a timeout for the Etcdclient #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So we've since changed the kubebuilder tests to fake etcdclient. So this shouldn't be an issue anymore (?). However, I agree with the general idea of a timeout to contact etcd. Is 150ms too short? What's that a timeout to? DNS resolution? First byte of actual data? Full response? |
|
@JamesLaverack i believe its the time until the response headers are fully received (so that the longpolling watch operations dont fail after the timeout expires). but +1 to incresing the timeout - how does 1s sound? |
|
Changed it to a 1 second timeout. |
adamhosier
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #77
This introduces a 1s time limit on the Etcdclient requests