Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

ENG-1523: build and unit test goss on windows travis CI. #4

Merged
merged 1 commit into from
Apr 10, 2019
Merged

ENG-1523: build and unit test goss on windows travis CI. #4

merged 1 commit into from
Apr 10, 2019

Conversation

stefan-improbable
Copy link

Testing strategy: travis.

petemounce
petemounce approved these changes Apr 10, 2019
View reviewed changes
Copy link

@petemounce petemounce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefan-improbable
Copy link
Author

stefan-improbable commented Apr 10, 2019 •
edited
Loading

Actually the build fails on windows, but this is expected:

system\file.go:98:16: undefined: syscall.Stat_t
system\file.go:158:32: undefined: syscall.Stat_t
system\file.go:176:32: undefined: syscall.Stat_t

@stefan-improbable stefan-improbable merged commit d6d7cbb into master Apr 10, 2019
@stefan-improbable stefan-improbable deleted the stefan/winbuild branch April 10, 2019 10:52
stefan-improbable added a commit that referenced this pull request May 23, 2019
@stefan-improbable
ENG-1523: run goss on windows CI. (#4)
8874133
petemounce pushed a commit that referenced this pull request Jun 25, 2019
@stefan-improbable
ENG-1523: run goss on windows CI. (#4)
de639d4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ca-johnson ca-johnson ca-johnson approved these changes

@efarem efarem efarem approved these changes

@petemounce petemounce petemounce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefan-improbable @petemounce @efarem @ca-johnson