Health check implementation (feature request #890) #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
the
size/XL
johanbrandhorst
suggested changes
Oct 7, 2021
Invited you as a collaborator, thanks. |
…implementation replaced with existing module, health check function simplified
johanbrandhorst
suggested changes
Oct 16, 2021
|
Thanks for your review work and useful suggestions, hopefully latest commits brought us close to merging the PR. |
Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
johanbrandhorst
approved these changes
Oct 20, 2021
|
Thanks Johan once again for useful suggestions throughout the review. |
|
Seems like our test provider (SauceLabs) is being a bit slow. CC @MarcusLongmuir. I've rerun the jobs twice, hopefully they will all pass now. |
|
Got there in the end, thanks for this contribution @zolkin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the health check functionality to both grpcweb and grpcwebproxy. The implementation is heavily based on existing grpc client health check implementation (see https://github.com/grpc/grpc-go/blob/master/health/client.go for more details)
Changes
Added health.go (exports ClientHealthCheck function) and health_test.go (tests for the new functionality) to grpcweb.
Added implementation of the health check functionality to the grpcwebproxy based on ClientHealthCheck function in grpcweb.
Added enable_health_check_service (default=false), enable_health_endpoint(default=false), health_endpoint_name ( default="_health"), health_service_name, (default="") run parameters for grpcwebproxy to control new health check functionality.
Verification
Apart from added tests manual testing was performed with grpcwebproxy to test whether proxy actually performs health checks and serves the results to the health endpoint.